From bfaacd6d5b1a06f75231dae4eacf940c806c904f Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Tue, 25 Jan 2022 20:22:03 -0800 Subject: [PATCH 01/10] Create plex.sh Deploy script for use with a local Plex Media Server. Could help resolve Issues #3474, #3893, and #285 --- deploy/plex.sh | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 deploy/plex.sh diff --git a/deploy/plex.sh b/deploy/plex.sh new file mode 100644 index 00000000..de076cc5 --- /dev/null +++ b/deploy/plex.sh @@ -0,0 +1,94 @@ +#!/usr/bin/env sh + +# Here is a script to deploy cert to local Plex Media Server on Debian. + +# The following environment variables must be set: +# +# PLEX_PKCS12_Password - Password used for the PKCS12 certificate + +#returns 0 means success, otherwise error. + + +# Settings for Plex Media Server: +# +# PLEX_PKCS12_password -- Password for the PKCS file. Required by plex +# PLEX_PKCS12_file -- Full PKCS file location, otherwise defaults to placing with the other certs in that domain with a pfx extension +# PLEX_sudo_required -- 1 = True, 0 = False. You may need to add "plex ALL=(ALL) NOPASSWD:/bin/systemctl restart plexmediaserver.service" to your sudo'ers file + +######## Public functions ##################### + +#domain keyfile certfile cafile fullchain +plex_deploy() { + _cdomain="$1" + _ckey="$2" + _ccert="$3" + _cca="$4" + _cfullchain="$5" + + _debug _cdomain "$_cdomain" + _debug _ckey "$_ckey" + _debug _ccert "$_ccert" + _debug _cca "$_cca" + _debug _cfullchain "$_cfullchain" + + _getdeployconf PLEX_PKCS12_password + _getdeployconf PLEX_PKCS12_file + _getdeployconf PLEX_sudo_required + + + _debug2 PLEX_PKCS12_password "$PLEX_PKCS12_password" + _debug2 PLEX_PKCS12_file "$PLEX_PKCS12_file" + _debug2 PLEX_sudo_required "$PLEX_sudo_required" + + + #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" + + + if [ -z "$PLEX_PKCS12_password" ]; then + _err "The PLEX_PKCS12_password variable is not defined. Plex requires a password for the certificate." + #_err "See: $_DEPLOY_PLEX_WIKI" + return 1 + fi + + if [ -z "$PLEX_PKCS12_file" ]; then + PLEX_PKCS12_file="$DOMAIN_PATH/$_cdomain.pfx" + fi + + _reload_cmd="" + + _debug "Generate import pkcs12" + _toPkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password" + if [ "$?" != "0" ]; then + _err "Error generating pkcs12. Please re-run with --debug and report a bug." + return 1 + fi + + if systemctl -q is-active plexmediaserver; then + _debug2 "Plex is active. Restarting..." + if [ -z "$PLEX_sudo_required" ]; then + _reload_cmd="systemctl restart plexmediaserver.service" + else + _reload_cmd="sudo systemctl restart plexmediaserver.service" + fi + fi + if [ -z "$_reload_cmd" ]; then + _info "Plex server is not active. Certificates installed, but skipping restart." + else + if eval "$_reload_cmd"; then + _info "Reload success!" + else + _err "Reload error" + return 1 + fi + fi + + _services_updated="${_services_updated} plexmediaserver" + _info "Install Plex Media Server certificate success!" + + # Successful, so save all (non-default) config: + _savedeployconf PLEX_PKCS12_password "$PLEX_PKCS12_password" + _savedeployconf PLEX_PKCS12_file "$PLEX_PKCS12_file" + _savedeployconf PLEX_sudo_required "$PLEX_sudo_required" + + return 0 +} From db49858f21d4cd0623e9961a12f6d9227d3594e9 Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Wed, 26 Jan 2022 11:14:56 -0800 Subject: [PATCH 02/10] Check/assign variables before printing debug2 --- deploy/plex.sh | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) mode change 100644 => 100755 deploy/plex.sh diff --git a/deploy/plex.sh b/deploy/plex.sh old mode 100644 new mode 100755 index de076cc5..05f29b6e --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -35,11 +35,6 @@ plex_deploy() { _getdeployconf PLEX_PKCS12_file _getdeployconf PLEX_sudo_required - - _debug2 PLEX_PKCS12_password "$PLEX_PKCS12_password" - _debug2 PLEX_PKCS12_file "$PLEX_PKCS12_file" - _debug2 PLEX_sudo_required "$PLEX_sudo_required" - #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" @@ -49,10 +44,20 @@ plex_deploy() { #_err "See: $_DEPLOY_PLEX_WIKI" return 1 fi + _debug2 PLEX_PKCS12_password "$PLEX_PKCS12_password" if [ -z "$PLEX_PKCS12_file" ]; then PLEX_PKCS12_file="$DOMAIN_PATH/$_cdomain.pfx" + _debug2 "Setting PLEX_PKCS12_file to default" fi + _debug2 PLEX_PKCS12_file "$PLEX_PKCS12_file" + + if [ -z "$PLEX_sudo_required" ]; then + PLEX_sudo_required=0 + _debug2 "Setting PLEX_PKCS12_file to default (0/False)" + fi + + _debug2 PLEX_sudo_required "$PLEX_sudo_required" _reload_cmd="" From b2be1eb278c47012990ae9db657c906cc1b14cdc Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Wed, 26 Jan 2022 11:18:16 -0800 Subject: [PATCH 03/10] Update to align with SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with 0. --- deploy/plex.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/deploy/plex.sh b/deploy/plex.sh index 05f29b6e..25be5385 100755 --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -62,8 +62,8 @@ plex_deploy() { _reload_cmd="" _debug "Generate import pkcs12" - _toPkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password" - if [ "$?" != "0" ]; then + + if ! _toPkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then _err "Error generating pkcs12. Please re-run with --debug and report a bug." return 1 fi From 238cd4bc5d7271224a58a030c7722ede0541c3ad Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Wed, 26 Jan 2022 11:20:35 -0800 Subject: [PATCH 04/10] Check for shfmt -w -i 2 plex.sh --- deploy/plex.sh | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/deploy/plex.sh b/deploy/plex.sh index 25be5385..97c1d6c3 100755 --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -8,9 +8,8 @@ #returns 0 means success, otherwise error. - # Settings for Plex Media Server: -# +# # PLEX_PKCS12_password -- Password for the PKCS file. Required by plex # PLEX_PKCS12_file -- Full PKCS file location, otherwise defaults to placing with the other certs in that domain with a pfx extension # PLEX_sudo_required -- 1 = True, 0 = False. You may need to add "plex ALL=(ALL) NOPASSWD:/bin/systemctl restart plexmediaserver.service" to your sudo'ers file @@ -34,46 +33,44 @@ plex_deploy() { _getdeployconf PLEX_PKCS12_password _getdeployconf PLEX_PKCS12_file _getdeployconf PLEX_sudo_required - - + #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" - - + if [ -z "$PLEX_PKCS12_password" ]; then _err "The PLEX_PKCS12_password variable is not defined. Plex requires a password for the certificate." #_err "See: $_DEPLOY_PLEX_WIKI" - return 1 + return 1 fi _debug2 PLEX_PKCS12_password "$PLEX_PKCS12_password" - + if [ -z "$PLEX_PKCS12_file" ]; then PLEX_PKCS12_file="$DOMAIN_PATH/$_cdomain.pfx" _debug2 "Setting PLEX_PKCS12_file to default" fi _debug2 PLEX_PKCS12_file "$PLEX_PKCS12_file" - + if [ -z "$PLEX_sudo_required" ]; then PLEX_sudo_required=0 _debug2 "Setting PLEX_PKCS12_file to default (0/False)" fi - + _debug2 PLEX_sudo_required "$PLEX_sudo_required" - + _reload_cmd="" - + _debug "Generate import pkcs12" - + if ! _toPkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then _err "Error generating pkcs12. Please re-run with --debug and report a bug." return 1 fi if systemctl -q is-active plexmediaserver; then - _debug2 "Plex is active. Restarting..." + _debug2 "Plex is active. Restarting..." if [ -z "$PLEX_sudo_required" ]; then _reload_cmd="systemctl restart plexmediaserver.service" - else - _reload_cmd="sudo systemctl restart plexmediaserver.service" + else + _reload_cmd="sudo systemctl restart plexmediaserver.service" fi fi if [ -z "$_reload_cmd" ]; then @@ -86,10 +83,10 @@ plex_deploy() { return 1 fi fi - + _services_updated="${_services_updated} plexmediaserver" _info "Install Plex Media Server certificate success!" - + # Successful, so save all (non-default) config: _savedeployconf PLEX_PKCS12_password "$PLEX_PKCS12_password" _savedeployconf PLEX_PKCS12_file "$PLEX_PKCS12_file" From 718774a948874c82d49ac4602d0e037dd7a62cfc Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Thu, 27 Jan 2022 07:26:18 -0800 Subject: [PATCH 05/10] Disable SC2154. There seems to be a bug in version 0.7 of shellcheck. Testing with shellcheck v0.8 doesn't yield any flags for SC2154. --- deploy/plex.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/deploy/plex.sh b/deploy/plex.sh index 97c1d6c3..6e8e8f78 100755 --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -1,4 +1,5 @@ #!/usr/bin/env sh +# shellcheck disable=SC2154 # Here is a script to deploy cert to local Plex Media Server on Debian. From 660d8bc4aca2e527e7e17128637bc8699f75b272 Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Sun, 16 Apr 2023 12:24:36 -0700 Subject: [PATCH 06/10] Update generation of PKCS12 cert to use modern encryption so that Plex doesn't barf. See also: https://forums.plex.tv/t/ssl-became-broken-after-latest-pms-update/837416/10 --- deploy/plex.sh | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/deploy/plex.sh b/deploy/plex.sh index 6e8e8f78..cd46597c 100755 --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -37,6 +37,21 @@ plex_deploy() { #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" + + _plex_to_pkcs() { + # The existing _toPkcs command doesn't have an option to specify cipher, so copied here + # to force using a modern cipher, as required by PMS: + # https://forums.plex.tv/t/ssl-became-broken-after-latest-pms-update/837416/4 + _cpfx="$1" + _ckey="$2" + _ccert="$3" + _cca="$4" + pfxPassword="$5" + + ${ACME_OPENSSL_BIN:-openssl} pkcs12 -export -out "$_cpfx" -certpbe AES-256-CBC -keypbe AES-256-CBC -macalg SHA256 -inkey "$_ckey" -in "$_ccert" -certfile "$_cca" -password "pass:$pfxPassword" + } + + if [ -z "$PLEX_PKCS12_password" ]; then _err "The PLEX_PKCS12_password variable is not defined. Plex requires a password for the certificate." #_err "See: $_DEPLOY_PLEX_WIKI" @@ -61,7 +76,7 @@ plex_deploy() { _debug "Generate import pkcs12" - if ! _toPkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then + if ! _plex_to_pkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then _err "Error generating pkcs12. Please re-run with --debug and report a bug." return 1 fi From 2c950d65b166faf432d020b2c056992c9910d495 Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Fri, 20 Dec 2024 09:22:36 -0800 Subject: [PATCH 07/10] Create plex_synology.sh --- deploy/plex_synology.sh | 111 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 deploy/plex_synology.sh diff --git a/deploy/plex_synology.sh b/deploy/plex_synology.sh new file mode 100644 index 00000000..82ec3fbb --- /dev/null +++ b/deploy/plex_synology.sh @@ -0,0 +1,111 @@ +#!/usr/bin/bash +# shellcheck disable=SC2154 + +# Here is a script to deploy cert to local Plex Media Server on Synology. +# Based on https://www.snbforums.com/threads/issue-lets-encrypt-certificate-with-acme-sh-use-it-with-synology-dsm-and-plex.70395/ + +# The following environment variables must be set: +# +# PLEX_PKCS12_Password - Password used for the PKCS12 certificate + +#returns 0 means success, otherwise error. + +# Settings for Plex Media Server: +# +# PLEX_PKCS12_password -- Password for the PKCS file. Required by plex +# PLEX_PKCS12_file -- Full PKCS file location, otherwise defaults to placing with the other certs in that domain with a pfx extension +# PLEX_sudo_required -- 1 = True, 0 = False. You may need to add "plex ALL=(ALL) NOPASSWD:/bin/systemctl restart plexmediaserver.service" to your sudo'ers file + +# Set Plex certificate location to /usr/local/share/Plex/plex_cert.pfx + +######## Public functions ##################### + +#domain keyfile certfile cafile fullchain +plex_synology_deploy() { + _cdomain="$1" + _ckey="$2" + _ccert="$3" + _cca="$4" + _cfullchain="$5" + + _debug _cdomain "$_cdomain" + _debug _ckey "$_ckey" + _debug _ccert "$_ccert" + _debug _cca "$_cca" + _debug _cfullchain "$_cfullchain" + + _getdeployconf PLEX_PKCS12_password + _getdeployconf PLEX_PKCS12_file + _getdeployconf PLEX_sudo_required + + #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" + + + _plex_to_pkcs() { + # The existing _toPkcs command doesn't have an option to specify cipher, so copied here + # to force using a modern cipher, as required by PMS: + # https://forums.plex.tv/t/ssl-became-broken-after-latest-pms-update/837416/4 + _cpfx="$1" + _ckey="$2" + _ccert="$3" + _cca="$4" + pfxPassword="$5" + + ${ACME_OPENSSL_BIN:-openssl} pkcs12 -export -out "$_cpfx" -certpbe AES-256-CBC -keypbe AES-256-CBC -macalg SHA256 -inkey "$_ckey" -in "$_ccert" -certfile "$_cca" -password "pass:$pfxPassword" + } + + + if [ -z "$PLEX_PKCS12_password" ]; then + _err "The PLEX_PKCS12_password variable is not defined. Plex requires a password for the certificate." + #_err "See: $_DEPLOY_PLEX_WIKI" + return 1 + fi + _debug2 PLEX_PKCS12_password "$PLEX_PKCS12_password" + + if [ -z "$PLEX_PKCS12_file" ]; then + PLEX_PKCS12_file="/usr/local/share/Plex/plex_cert.pfx" + _debug2 "Setting PLEX_PKCS12_file to default" + fi + _debug2 PLEX_PKCS12_file "$PLEX_PKCS12_file" + + if [ -z "$PLEX_sudo_required" ]; then + PLEX_sudo_required=0 + _debug2 "Setting PLEX_PKCS12_file to default (0/False)" + fi + + _debug2 PLEX_sudo_required "$PLEX_sudo_required" + + _reload_cmd="" + + _debug "Generate import pkcs12" + + if ! _plex_to_pkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then + _err "Error generating pkcs12. Please re-run with --debug and report a bug." + return 1 + fi + + if systemctl -q is-active pkgctl-PlexMediaServer.service; then + _debug2 "Plex is active. Restarting..." + _reload_cmd="/usr/syno/bin/synopkg restart PlexMediaServer" + fi + if [ -z "$_reload_cmd" ]; then + _info "Plex server is not active. Certificates installed, but skipping restart." + else + if eval "$_reload_cmd"; then + _info "Reload success!" + else + _err "Reload error" + return 1 + fi + fi + + _services_updated="${_services_updated} plexmediaserver" + _info "Install Plex Media Server certificate success!" + + # Successful, so save all (non-default) config: + _savedeployconf PLEX_PKCS12_password "$PLEX_PKCS12_password" + _savedeployconf PLEX_PKCS12_file "$PLEX_PKCS12_file" + _savedeployconf PLEX_sudo_required "$PLEX_sudo_required" + + return 0 +} From f802fb7240a2972cb80fd128287368da93446a2b Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Tue, 10 Jun 2025 07:57:02 -0700 Subject: [PATCH 08/10] Fix formatting --- deploy/plex.sh | 4 +--- deploy/plex_synology.sh | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/deploy/plex.sh b/deploy/plex.sh index cd46597c..d1036468 100755 --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -37,7 +37,6 @@ plex_deploy() { #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" - _plex_to_pkcs() { # The existing _toPkcs command doesn't have an option to specify cipher, so copied here # to force using a modern cipher, as required by PMS: @@ -51,7 +50,6 @@ plex_deploy() { ${ACME_OPENSSL_BIN:-openssl} pkcs12 -export -out "$_cpfx" -certpbe AES-256-CBC -keypbe AES-256-CBC -macalg SHA256 -inkey "$_ckey" -in "$_ccert" -certfile "$_cca" -password "pass:$pfxPassword" } - if [ -z "$PLEX_PKCS12_password" ]; then _err "The PLEX_PKCS12_password variable is not defined. Plex requires a password for the certificate." #_err "See: $_DEPLOY_PLEX_WIKI" @@ -76,7 +74,7 @@ plex_deploy() { _debug "Generate import pkcs12" - if ! _plex_to_pkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then + if ! _plex_to_pkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then _err "Error generating pkcs12. Please re-run with --debug and report a bug." return 1 fi diff --git a/deploy/plex_synology.sh b/deploy/plex_synology.sh index 82ec3fbb..f98b084c 100644 --- a/deploy/plex_synology.sh +++ b/deploy/plex_synology.sh @@ -40,7 +40,6 @@ plex_synology_deploy() { #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" - _plex_to_pkcs() { # The existing _toPkcs command doesn't have an option to specify cipher, so copied here # to force using a modern cipher, as required by PMS: @@ -54,7 +53,6 @@ plex_synology_deploy() { ${ACME_OPENSSL_BIN:-openssl} pkcs12 -export -out "$_cpfx" -certpbe AES-256-CBC -keypbe AES-256-CBC -macalg SHA256 -inkey "$_ckey" -in "$_ccert" -certfile "$_cca" -password "pass:$pfxPassword" } - if [ -z "$PLEX_PKCS12_password" ]; then _err "The PLEX_PKCS12_password variable is not defined. Plex requires a password for the certificate." #_err "See: $_DEPLOY_PLEX_WIKI" @@ -79,7 +77,7 @@ plex_synology_deploy() { _debug "Generate import pkcs12" - if ! _plex_to_pkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then + if ! _plex_to_pkcs "$PLEX_PKCS12_file" "$_ckey" "$_ccert" "$_cca" "$PLEX_PKCS12_password"; then _err "Error generating pkcs12. Please re-run with --debug and report a bug." return 1 fi From 948c41c4fb56ff1704fc6e5b96f71ae7e79357be Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Tue, 10 Jun 2025 20:31:42 -0700 Subject: [PATCH 09/10] support PLEX_RELOAD environment variable to override the Plex restart command --- deploy/plex.sh | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/deploy/plex.sh b/deploy/plex.sh index d1036468..f69f5913 100755 --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -14,6 +14,8 @@ # PLEX_PKCS12_password -- Password for the PKCS file. Required by plex # PLEX_PKCS12_file -- Full PKCS file location, otherwise defaults to placing with the other certs in that domain with a pfx extension # PLEX_sudo_required -- 1 = True, 0 = False. You may need to add "plex ALL=(ALL) NOPASSWD:/bin/systemctl restart plexmediaserver.service" to your sudo'ers file +# PLEX_RELOAD -- Optional custom command to restart Plex. If not set, the script will try +# to restart the service via systemctl when Plex is detected as active. ######## Public functions ##################### @@ -34,6 +36,7 @@ plex_deploy() { _getdeployconf PLEX_PKCS12_password _getdeployconf PLEX_PKCS12_file _getdeployconf PLEX_sudo_required + _getdeployconf PLEX_RELOAD #_DEPLOY_PLEX_WIKI="https://github.com/acmesh-official/acme.sh/wiki/deploy-to-plex" @@ -69,8 +72,9 @@ plex_deploy() { fi _debug2 PLEX_sudo_required "$PLEX_sudo_required" + _debug2 PLEX_RELOAD "$PLEX_RELOAD" - _reload_cmd="" + _reload_cmd="$PLEX_RELOAD" _debug "Generate import pkcs12" @@ -79,12 +83,14 @@ plex_deploy() { return 1 fi - if systemctl -q is-active plexmediaserver; then - _debug2 "Plex is active. Restarting..." - if [ -z "$PLEX_sudo_required" ]; then - _reload_cmd="systemctl restart plexmediaserver.service" - else - _reload_cmd="sudo systemctl restart plexmediaserver.service" + if [ -z "$_reload_cmd" ]; then + if systemctl -q is-active plexmediaserver; then + _debug2 "Plex is active. Restarting..." + if [ "$PLEX_sudo_required" = "1" ]; then + _reload_cmd="sudo systemctl restart plexmediaserver.service" + else + _reload_cmd="systemctl restart plexmediaserver.service" + fi fi fi if [ -z "$_reload_cmd" ]; then @@ -105,6 +111,7 @@ plex_deploy() { _savedeployconf PLEX_PKCS12_password "$PLEX_PKCS12_password" _savedeployconf PLEX_PKCS12_file "$PLEX_PKCS12_file" _savedeployconf PLEX_sudo_required "$PLEX_sudo_required" + _savedeployconf PLEX_RELOAD "$PLEX_RELOAD" return 0 } From 757958e2b79cc7fde1f7dc64713fd6b4179c281b Mon Sep 17 00:00:00 2001 From: Andrew Ferguson Date: Tue, 10 Jun 2025 20:40:09 -0700 Subject: [PATCH 10/10] Remove disable=SC2154 --- deploy/plex.sh | 1 - deploy/plex_synology.sh | 1 - 2 files changed, 2 deletions(-) mode change 100644 => 100755 deploy/plex_synology.sh diff --git a/deploy/plex.sh b/deploy/plex.sh index f69f5913..5730c1cf 100755 --- a/deploy/plex.sh +++ b/deploy/plex.sh @@ -1,5 +1,4 @@ #!/usr/bin/env sh -# shellcheck disable=SC2154 # Here is a script to deploy cert to local Plex Media Server on Debian. diff --git a/deploy/plex_synology.sh b/deploy/plex_synology.sh old mode 100644 new mode 100755 index f98b084c..99529531 --- a/deploy/plex_synology.sh +++ b/deploy/plex_synology.sh @@ -1,5 +1,4 @@ #!/usr/bin/bash -# shellcheck disable=SC2154 # Here is a script to deploy cert to local Plex Media Server on Synology. # Based on https://www.snbforums.com/threads/issue-lets-encrypt-certificate-with-acme-sh-use-it-with-synology-dsm-and-plex.70395/