Incorporated changes after code analasys.

This commit is contained in:
Klaas Eenkhoorn 2018-08-03 12:45:10 +02:00
parent b92c0145a3
commit fb5b41a4fc

View File

@ -83,9 +83,8 @@ dns_cpaneldns_rm() {
host="$(echo "$1" | sed "s/\.$zone\$//")"
record=$2
while _dns_cpaneldns_get_record $zone $host $record ;
do
record_id="$( _dns_cpaneldns_get_record $zone $host $record )"
while _dns_cpaneldns_get_record "$zone" "$host" "$record"; do
record_id="$(_dns_cpaneldns_get_record "$zone" "$host" "$record")"
if [ ! -z "$record_id" ]; then
_debug zone "$zone"
@ -206,9 +205,9 @@ _dns_cpaneldns_get_record() {
host=$2
record=$3
_debug zone $zone
_debug host $host
_debug record $record
_debug zone "$zone"
_debug host "$host"
_debug record "$record"
_dns_cpaneldns_http_api_call "cpanel_jsonapi_module=ZoneEdit" "cpanel_jsonapi_func=fetchzone_records&domain=$zone&$name=$host&type=TXT&txtdata=$record"
if ! _contains "$response" "\"line\":"; then
@ -216,13 +215,13 @@ _dns_cpaneldns_get_record() {
return 1
fi
if $respose ;
if $response;
then
recordlist="$(echo "$response" | tr '{' "\n" | grep "$record" | _head_n 1 )"
record_id="$(echo "$recordlist" | tr ',' "\n" | grep -E '^"line"' | sed -re 's/^\"line\"\:\"([0-9]+)\"$/\1/g' | cut -d ":" -f 2)"
echo $record_id
echo "$record_id"
_debug record_id $record_id
_debug record_id "$record_id"
return 0
fi